Issue 3632 - modify float is float to do a bitwise compare #724
Conversation
Make 'is' between floats and structs containing floats consistent at run-time and compile-time. This fixes the padding issue of the previous fix.
|
Actually never mind it needs phobos changes too, I'll just remove the |
Issue 3632 - modify float is float to do a bitwise compare
| @@ -204,6 +204,9 @@ int StructDeclaration::needOpEquals() | |||
| if (hasIdentityEquals) | |||
| goto Lneed; | |||
|
|
|||
| if (isUnionDeclaration()) | |||
| goto Ldontneed; | |||
|
|
|||
There was a problem hiding this comment.
Reverted the changes to clone.c, as they broke Phobos std.algorithm unittests.
|
Had to revert the rest, too. xtest46.d fails on OSX. Patch needs more work & testing. |
|
Yeah sorry, I needed to cut out the |
|
this pull request also clearly failed in the pull tester so was a bad candidate for merging: http://d.puremagic.com/test-results/pull-history.ghtml?projectid=1&pullid=724 |
|
Yeah, even when the master branch is broken, the pull history should show that the pull passed with earlier versions. if (walterReviewPassed)
{
if (pullTesterState == passing)
pull();
else if (masterTesterState == failing && pullTesterHistory == good)
pull();
else
dontPull();
}
else
{
rejectPull();
} |
|
if masterState == failing goFixMasterAndQuitLookingAtPulls(); |
|
There is still a delay between master getting fixed and the pulls moving back from red to green. |
Small fix for opAssign(T)
Make 'is' between floats and structs containing floats consistent at run-time and compile-time.
This fixes the padding issue of the previous fix.
http://d.puremagic.com/issues/show_bug.cgi?id=3632
@9rnsr This includes your fix for 3789 from pull #387 - if you can put those changes into a single commit I'll rebase on top of that instead of copying your fix.